#44 Add owner authorization check to keyring membership operations

open medium · sable · 2026-03-02 23:37 · security · Phase 3: Keyrings

Comments — 1

sable note 2026-03-02 23:37

Blackbox report finding 2.5: add_member and remove_member in opake-core don't verify that the caller (session DID) matches the authority in the keyring's AT-URI. The PDS enforces repo-level write access so this isn't exploitable in practice, but the library should guard against logic errors where e.g. a member's client accidentally tries to modify someone else's keyring. Fix: in add_member() and remove_member(), compare client.session().did against the AT-URI authority and return an error if they don't match. Defense-in-depth, not a live vulnerability.

Generated 2026-03-03 02:53 UTC